libscie/researchequals-api
1
0
Fork 0
Code Issues 18 Pull requests Projects Releases Packages Activity

fix(test): robustify integration tests #58

New issue
Closed
opened 2025-08-12 09:34:16 +00:00 by chartgerink · 0 comments
chartgerink commented 2025-08-12 09:34:16 +00:00
Owner
Copy link

Currently, integration tests can rely on synchronous state evaluations. These include exact number of objects returned. This is not robust and leads to errors that are technically not errors.

In order to make those tests more robust, we can reduce reliance on synchronous state in asynchronous functions. Or we can dynamically evaluate state right before the evaluations take place, but that may be subject to race conditions.

In general, every integration test needs to be reviewed for this.

  • affiliation-crud.rs
  • authorships-crud.rs
  • common.rs
  • email-verification.rs
  • institutions-crud.rs
  • integration-auth.rs
  • oidc-integration.rs
  • oidc-redis.rs
  • outputs-crud.rs
  • reset-password.rs
  • ror-integration.rs
  • upload-avatar.rs
  • upload-integration.rs
  • users-crud.rs
  • versions-crud.rs
Currently, integration tests can rely on synchronous state evaluations. These include exact number of objects returned. This is not robust and leads to errors that are technically not errors. In order to make those tests more robust, we can reduce reliance on synchronous state in asynchronous functions. Or we can dynamically evaluate state right before the evaluations take place, but that may be subject to race conditions. In general, every integration test needs to be reviewed for this. - [x] affiliation-crud.rs - [x] authorships-crud.rs - [x] common.rs - [x] email-verification.rs - [x] institutions-crud.rs - [x] integration-auth.rs - [x] oidc-integration.rs - [x] oidc-redis.rs - [x] outputs-crud.rs - [x] reset-password.rs - [x] ror-integration.rs - [x] upload-avatar.rs - [x] upload-integration.rs - [x] users-crud.rs - [x] versions-crud.rs
Sign in to join this conversation.
No Branch/Tag specified
Branches Tags
main
No results found.
Labels
Clear labels   
bug

Something is not working

  
critical

issues that are blocking other work, high importance + urgent

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
future

Not on the docket right now. Keeping the issue for future work.

  
help wanted

Need some help

  
invalid

Something is wrong

  
question

More information is needed

  
wontfix

This won't be fixed

No labels
bug
critical
duplicate
enhancement
future
help wanted
invalid
question
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: libscie/researchequals-api#58
No description provided.
Delete branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?