libscie/researchequals-api
1
0
Fork 0
Code Issues 18 Pull requests Projects Releases Packages Activity

chore(devex): make code more consistent #29

New issue
Closed
opened 2025-07-28 12:54:01 +00:00 by chartgerink · 3 comments
chartgerink commented 2025-07-28 12:54:01 +00:00
Owner
Copy link

Lots of bits and bobs are inconsistent throughout the codebase. Before a stable release, it is good to make them more consistent.

  • Migrations
  • Tests --> #31
  • check where routes can be upgraded to idempotent PUT instead of POST (most often in case of updating a record)
  • ensure consistency in route setups (use web::scope icw .route)
  • separate out integration tests further for granular feedback without logging -> #48
  • check unit tests across the board -> #48
  • create consistent nesting for models, handlers, etc. now it's all over the place

Other suggestions welcome :)

Lots of bits and bobs are inconsistent throughout the codebase. Before a stable release, it is good to make them more consistent. - [x] Migrations - [x] Tests --> #31 - [x] check where routes can be upgraded to idempotent `PUT` instead of `POST` (most often in case of updating a record) - [x] ensure consistency in route setups (use `web::scope` icw `.route`) - [ ] separate out integration tests further for granular feedback without logging -> #48 - [ ] check unit tests across the board -> #48 - [ ] ~~create consistent nesting for models, handlers, etc. now it's all over the place~~ Other suggestions welcome :)
chartgerink commented 2025-08-08 09:59:00 +00:00
Author
Owner
Copy link
  • Reduce logging noise in tests
- [x] Reduce logging noise in tests
chartgerink commented 2025-08-08 10:07:11 +00:00
Author
Owner
Copy link
  • add integration tests for OIDC -> #47
- [ ] add integration tests for OIDC -> #47
chartgerink commented 2025-08-08 11:00:19 +00:00
Author
Owner
Copy link
  • ensure continuous and singular imports of relevant paths (no duplicate import paths like crate::{1} and crate::{2} - this should be combined into crate::{1,2})
  • use common functions consistently in tests
- [x] ensure continuous and singular imports of relevant paths (no duplicate import paths like crate::{1} and crate::{2} - this should be combined into `crate::{1,2}`) - [x] use common functions consistently in tests
Sign in to join this conversation.
No Branch/Tag specified
Branches Tags
main
No results found.
Labels
Clear labels   
bug

Something is not working

  
critical

issues that are blocking other work, high importance + urgent

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
future

Not on the docket right now. Keeping the issue for future work.

  
help wanted

Need some help

  
invalid

Something is wrong

  
question

More information is needed

  
wontfix

This won't be fixed

No labels
bug
critical
duplicate
enhancement
future
help wanted
invalid
question
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: libscie/researchequals-api#29
No description provided.
Delete branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?